You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I updated the package version in pyproject.toml and made sure the first 3 numbers match git describe --tags --abbrev=8 in OpenBLAS at the OPENBLAS_COMMIT. If I did not update OPENBLAS_COMMIT, I incremented the wheel build number (i.e. 0.3.29.0.0 to 0.3.29.0.1)
Can I ask what motivated the attempt to try making this switch? Using Clang seems healthier on macOS, since that's how everything gets compiled and it avoids pulling in C/C++ runtime libs.
There is a floating point error emmited in zgetrf on macos-arm64 that I am trying to track down. It does not appear on the cirrusCI builds, but can be reproduced by rebuilding locally. I am trying to determine what combination of compiler + processor triggers the FPE. Locally, when I build OpenBLAS with GCC I do not see the FPE, so I was trying to replicate that success here.
I can't see so quickly if zgetrf uses a BLAS function that uses SME, but if so it could be similar to numpy/numpy#29223.
I also noticed that the macos-arm64 builds on this repo still use macos-13 x86-64 runners, which probably doesn't make too much sense anymore and will make it hard or impossible to see this in CI. Switching to macos-latest would be useful either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git describe --tags --abbrev=8in OpenBLAS at theOPENBLAS_COMMIT. If I did not updateOPENBLAS_COMMIT, I incremented the wheel build number (i.e. 0.3.29.0.0 to 0.3.29.0.1)